Revert "Impl Clone for header::ToStrError (#203)"#204
Merged
Conversation
Errors explicitly avoid `Clone` in order to be future compatible with adding inner field types that may not be `Clone`. Many Rust errors do not impl `Clone`, so adding a `Clone` impl to an error prevents it from containing other errors in the future. This reverts commit 46ee6f8.
seanmonstar
approved these changes
May 25, 2018
This was referenced Jul 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Errors explicitly avoid
Clonein order to be future compatible withadding inner field types that may not be
Clone. Many Rust errors donot impl
Clone, so adding aCloneimpl to an error prevents it fromcontaining other errors in the future.
This reverts commit 46ee6f8.