Add missing TryFrom<String> and TryFrom<Vec<u8>> impls.#477
Merged
seanmonstar merged 1 commit intohyperium:masterfrom Apr 21, 2021
Arnavion:tryfrom
Merged
Add missing TryFrom<String> and TryFrom<Vec<u8>> impls.#477seanmonstar merged 1 commit intohyperium:masterfrom Arnavion:tryfrom
seanmonstar merged 1 commit intohyperium:masterfrom
Arnavion:tryfrom
Conversation
Also fix PathAndQuery's TryFrom<String> impl to not copy the bytes into a new Bytes.
Contributor
Author
|
@seanmonstar Ping. |
seanmonstar
approved these changes
Apr 21, 2021
Member
|
Thanks for catching this! |
BenxiangGe
pushed a commit
to BenxiangGe/http
that referenced
this pull request
Jul 26, 2021
Also fix PathAndQuery's TryFrom<String> impl to not copy the bytes into a new Bytes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also fix PathAndQuery's TryFrom impl to not copy the bytes into
a new Bytes.