Add TryFrom implementations for owned types for HeaderName#479
Merged
seanmonstar merged 1 commit intohyperium:masterfrom Apr 16, 2021
Merged
Add TryFrom implementations for owned types for HeaderName#479seanmonstar merged 1 commit intohyperium:masterfrom
seanmonstar merged 1 commit intohyperium:masterfrom
Conversation
`HeaderValue` implements `TryFrom` over both reference and owned types, but `HeaderName` does not. This seemed like an accidental omission to me rather than something intentionally absent. Including this conversion slightly increases ergonomics by allowing you to create a `HeaderMap` from a `HashMap<String, String>` and in similar other constraints. See also sagebind/isahc#314.
seanmonstar
approved these changes
Apr 16, 2021
Member
seanmonstar
left a comment
seanmonstar
left a comment
There was a problem hiding this comment.
Yep, looks like an oversight to me, thanks!
BenxiangGe
pushed a commit
to BenxiangGe/http
that referenced
this pull request
Jul 26, 2021
) `HeaderValue` implements `TryFrom` over both reference and owned types, but `HeaderName` does not. This seemed like an accidental omission to me rather than something intentionally absent. Including this conversion slightly increases ergonomics by allowing you to create a `HeaderMap` from a `HashMap<String, String>` and in similar other constraints. See also sagebind/isahc#314.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
HeaderValueimplementsTryFromover both reference and owned types, butHeaderNamedoes not. This seemed like an accidental omission to me rather than something intentionally absent. Including this conversion slightly increases ergonomics by allowing you to create aHeaderMapfrom aHashMap<String, String>and in similar other constraints.See also sagebind/isahc#314.