pool-ng #230

seanmonstar · 2025-09-16T14:00:21Z

Just a combined pull request for generating docs previews and some CI testing, look at the separate PRs for the individual pieces.

seanmonstar · 2025-09-16T14:45:37Z

/rustdoc-preview

github-actions · 2025-09-16T14:46:04Z

📝 Rustdoc preview for this PR: View docs

seanmonstar · 2025-09-19T20:44:30Z

/rustdoc-preview

github-actions · 2025-09-19T20:44:58Z

📝 Rustdoc preview for this PR: View docs

sjcobb2022

Looking great overall. Will test in some crates later on in the week

sjcobb2022 · 2025-10-13T15:07:53Z

examples/client.rs

-use http_body_util::Empty;
-use hyper::Request;
-use hyper_util::client::legacy::{connect::HttpConnector, Client};
+use hyper_util::client::pool;


nit: rename file to client_pool

sjcobb2022 · 2025-10-13T15:09:58Z

examples/client.rs

+
+    let mut p = pool::Cache::new(http1).build();
+
+    let mut c = p.call(http::Uri::from_static("http://hyper.rs")).await?;


nit: use consistent uri for all calls.

sjcobb2022 · 2025-10-13T22:24:41Z

examples/client.rs

-    let req = Request::builder()
-        .uri(url)
-        .body(Empty::<bytes::Bytes>::new())?;
+async fn send_nego() -> Result<(), Box<dyn std::error::Error + Send + Sync>> {


nit: send_negotiate

sjcobb2022 · 2025-10-13T22:26:22Z

examples/client.rs

+
+    for _ in 0..5 {
+        let mut c = svc
+            .call(http::Uri::from_static("http://localhost:3000"))


change to hyper.rs (or keep consistent with all other tests)

sjcobb2022 · 2025-10-13T22:43:15Z

src/client/pool/map.rs

+//! The map isn't a typical `Service`, but rather stand-alone type that can map
+//! requests to a key and  service factory. This is because the service is more
+//! of a router, and cannot determine which inner service to check for
+//! backpressure since it's not know until the request is made.
+//!
+//! The map implementation allows customization of extracting a key, and how to
+//! construct a MakeService for that key.


Potential rewrite:

This map is not a traditional Service; instead, it is a standalone type that allows users to associate incoming keys with service factories. For each request, a key is extracted and used to select or construct a corresponding service.

Because this service acts more like a router, it cannot determine which inner service to check for backpressure ahead of time; the appropriate service is only known once a request has been received.

sjcobb2022 · 2025-10-13T22:58:24Z

src/client/pool/map.rs

+        let mut pool = super::Map::builder().keys(|_| "a").values(|_| "b").build();
+        pool.service(&"hello");
+    }
+}


#[test] fn it_returns_same_service_for_same_key() { let mut pool = Map::builder() .keys(|s: &&str| *s) .values(|_| { String::from("service") }) .build(); let service1 = pool.service(&"foo") as *const String; let service2 = pool.service(&"foo") as *const String; // Should be the same pointer. assert_eq!(service1, service2); } #[test] fn it_returns_different_service_for_different_keys() { let mut pool = Map::builder() .keys(|s: &&str| *s) .values(|s| format!("service-for-{}", s)) .build(); let service1 = pool.service(&"foo") as *const String; let service2 = pool.service(&"bar") as *const String; // Should NOT be the same pointer (different key/service) assert_ne!(service1, service2); // Optionally, check the actual value assert_eq!(pool.service(&"foo"), "service-for-foo"); assert_eq!(pool.service(&"bar"), "service-for-bar"); }

sjcobb2022 · 2025-10-13T23:04:02Z

src/client/pool/singleton.rs

+//! The singleton pool combines a MakeService that should only produce a single
+//! active connection. It can bundle all concurrent calls to it, so that only
+//! one connection is made. All calls to the singleton will return a clone of
+//! the inner service once established.
+//!
+//! This fits the HTTP/2 case well.


Take it or leave it:

The singleton pool manages a MakeService that should only produce a single active connection.

src/client/pool/map.rs

sjcobb2022 · 2025-11-03T21:06:55Z

src/client/pool/map.rs

+    T::Key: Eq + std::hash::Hash,
+{
+    /// Get a service after extracting the key from `req`.
+    pub fn service(&mut self, req: &Req) -> &mut T::Service {


Would it still be worth implementing Service for this, which just calls the underlying method? Means we have a "consistent" API for all the pool methods.

So far I still think it's proper to not provide the impl. Wouldn't be a problem to eventually add one if so needed.

Yeh sounds good.

Actually, if we want to store Map, it would be much nicer if we had Service for it, since that means we can name the type that we can name the type of the returned service.

e.g. we can store cache, singleton, and negotiate because they can be abstracted away into Services over children services, but since target is private we can't really name it.

seanmonstar force-pushed the pool-ng branch from 4d6bdd7 to 47785bc Compare September 16, 2025 14:01

This comment was marked as outdated.

Sign in to view

seanmonstar force-pushed the pool-ng branch from 47785bc to 79b11b8 Compare September 16, 2025 14:36

This comment was marked as outdated.

Sign in to view

seanmonstar force-pushed the pool-ng branch from 79b11b8 to ded06e9 Compare September 16, 2025 14:45

seanmonstar force-pushed the pool-ng branch 2 times, most recently from 778d49d to 7b668a6 Compare September 19, 2025 20:38

sjcobb2022 reviewed Oct 13, 2025

View reviewed changes

sjcobb2022 reviewed Oct 20, 2025

View reviewed changes

src/client/pool/map.rs Show resolved Hide resolved

seanmonstar added 2 commits November 3, 2025 09:43

feat(pool): add a Singleton pool type

bfbfa0d

feat(pool): add a Cache pooling service

f5b6508

sjcobb2022 reviewed Nov 3, 2025

View reviewed changes

seanmonstar added 4 commits November 4, 2025 08:25

feat(pool): add a Negotiate pooling service

e644e08

feat(pool): add a Map pool service type

a9883e6

wip: pool-expire

32322c2

pools wip

e02e3f3

seanmonstar force-pushed the pool-ng branch from 7b668a6 to e02e3f3 Compare November 4, 2025 20:57


		let mut p = pool::Cache::new(http1).build();

		let mut c = p.call(http::Uri::from_static("http://hyper.rs")).await?;

Uh oh!

pool-ng #230

Are you sure you want to change the base?

pool-ng #230

Uh oh!

Conversation

seanmonstar commented Sep 16, 2025

Uh oh!

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

seanmonstar commented Sep 16, 2025

Uh oh!

github-actions bot commented Sep 16, 2025

Uh oh!

seanmonstar commented Sep 19, 2025

Uh oh!

github-actions bot commented Sep 19, 2025

Uh oh!

sjcobb2022 left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sjcobb2022 Nov 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

sjcobb2022 Nov 4, 2025 •

edited

Loading