fix: allow proxy env URIs without password #241
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karanabe
changed the title
seanmonstar
requested changes
Nov 3, 2025
karanabe
force-pushed
the
fix/parse-env-uri
branch
from
2ce6be0 to
fc38fa2
Compare
|
Glad to help! I was looking for something to contribute to in hyperium and found this one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change allows proxy environment URIs to omit a password, reuses the decoded username and password when building basic and raw auth, and adds tests covering HTTP proxies without passwords.
Closes hyperium/hyper#3972