fix(client): parse Windows per-scheme proxies#285
Open
cyphercodes wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes hyperium/hyper#4067.
Summary
ProxyServerper-scheme values such ashttp=...;https=...;socks=....socks=as a SOCKS fallback for both HTTP and HTTPS destinations while preserving explicithttp=/https=entries and existing environment-derived values.ftp=instead of treating the whole registry string as one proxy URI.Tests
cargo fmt --all --checkcargo test --features client-proxy test_windows_proxy_server -- --nocapturecargo test --features client-proxy client::proxy::matcher::tests -- --nocapturecargo test --all-features client::proxy::matcher::tests -- --nocapturecargo check --target x86_64-pc-windows-gnu --features "client-proxy client-proxy-system"cargo test --all-features