Skip to content

fix(client): parse Windows per-scheme proxies#285

Open
cyphercodes wants to merge 1 commit into
hyperium:masterfrom
cyphercodes:fix-windows-proxyserver-schemes
Open

fix(client): parse Windows per-scheme proxies#285
cyphercodes wants to merge 1 commit into
hyperium:masterfrom
cyphercodes:fix-windows-proxyserver-schemes

Conversation

@cyphercodes
Copy link
Copy Markdown

Fixes hyperium/hyper#4067.

Summary

  • Parse Windows WinINET ProxyServer per-scheme values such as http=...;https=...;socks=....
  • Apply socks= as a SOCKS fallback for both HTTP and HTTPS destinations while preserving explicit http=/https= entries and existing environment-derived values.
  • Ignore unrelated per-scheme entries such as ftp= instead of treating the whole registry string as one proxy URI.

Tests

  • cargo fmt --all --check
  • cargo test --features client-proxy test_windows_proxy_server -- --nocapture
  • cargo test --features client-proxy client::proxy::matcher::tests -- --nocapture
  • cargo test --all-features client::proxy::matcher::tests -- --nocapture
  • cargo check --target x86_64-pc-windows-gnu --features "client-proxy client-proxy-system"
  • cargo test --all-features

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Windows system proxy: per-scheme ProxyServer format (e.g. socks=127.0.0.1:1080) not parsed

1 participant