docs(server): Add an example of serving files #1404
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jolhoeft
force-pushed
the
file_example
branch
from
710afb9 to
f25fd4b
Compare
jolhoeft
changed the title
jolhoeft
changed the title
jolhoeft
force-pushed
the
file_example
branch
3 times, most recently
from
737e2e9 to
68030c9
Compare
Contributor
Author
|
Two threads are not needed. I had a mental block, thinking I could only have one channel per thread, which isn't true. I've updated this example. There are still two versions, because the non-streaming version is simpler for small amounts of data/processing. |
jolhoeft
force-pushed
the
file_example
branch
from
68030c9 to
7d2cce0
Compare
Member
|
Awesome work! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here is an example of serving files in a separate thread. It should cover most cases where a separate thread is required, such as accessing a database.
There are actually two approaches illustrated here. One reads the whole file into memory, the other streams the file in chunks, but requires a second thread for the Response body. I don't like this two threaded approach, but haven't been able to figure out a way around it. Suggestions for a better approach would be appreciated.
I am working on an update to the guide pages to go with this example (which I will submit along with the Request body processing guide pages I'm working on.)