Skip to content

Conversation

@jolhoeft
Copy link
Contributor

No description provided.

@jolhoeft
Copy link
Contributor Author

I don't understand the Travis errors. They are failing claiming I am not using use std::ascii::AsciiExt;, but only in nightly and beta. I am using that import though, and when I build with nightly/beta locally, everything is fine.

@seanmonstar
Copy link
Member

It's because starting in Rust 1.23 (which is currently in beta), the methods that were on AsciiExt are now inherent methods, and so the imported trait is not "used" on >=1.23. You need to slap a #[allow(unused)] on the use std::ascii::AsciiExt line.

@jolhoeft
Copy link
Contributor Author

Odd that I can't reproduce it locally, but it should be fixed now.

@seanmonstar seanmonstar merged commit 6fde13f into hyperium:master Dec 28, 2017
@seanmonstar
Copy link
Member

Thanks, these are really useful!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants