Skip to content

Conversation

@adwhit
Copy link

@adwhit adwhit commented Jan 21, 2015

TypeId has moved from std::intrinsics to std::any

@GitCop
Copy link

GitCop commented Jan 21, 2015

There were the following issues with your Pull Request

  • Commit: 893e8a9
    • Commits must be in the following format: %{type}(%{scope}): %{description}

Guidelines are available at https://github.com/hyperium/hyper/blob/master/CONTRIBUTING.md


This message was auto-generated by https://gitcop.com

@reem
Copy link
Contributor

reem commented Jan 21, 2015

@adwhit can you update this PR to conform to gitcop? If you don't feel like it that's fine, I'll just merge #263 instead, but want to give you time since this PR does predate #263.

@adwhit adwhit changed the title update TypeId import location to "any" module fix(imports): Update TypeId import location to "any" module Jan 21, 2015
@adwhit
Copy link
Author

adwhit commented Jan 21, 2015

Thanks, done

@ProtectedMode
Copy link
Contributor

@adwhit, GitCop is talking about your commit message, just amend the message and force push it.

@ProtectedMode
Copy link
Contributor

@reem, could you please pull this? I want to see if I can get Iron's static working.

reem added a commit that referenced this pull request Jan 21, 2015
fix(imports): Update TypeId import location to "any" module
@reem reem merged commit 6812af0 into hyperium:master Jan 21, 2015
@reem
Copy link
Contributor

reem commented Jan 21, 2015

@ProtectedMode I've pulled but I'm on my phone so I can't update cargo yet. I'll update it as soon as I get home.

@ProtectedMode
Copy link
Contributor

@reem, okay, thank you.

@reem
Copy link
Contributor

reem commented Jan 21, 2015

@ProtectedMode updated cargo

@adwhit adwhit deleted the update-typeid-location branch January 21, 2015 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants