fix(client): distinguish the H2CheckoutIsClosed error #3008
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
I think this looks correct. Have you found that using this code fixes the case you noticed? What did it fix? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have occurred a bug when using hyper and reqwest to send HTTP requests, and I have tried to fix it.
Please first look at the case below the modified code. If the checkout occurs error, it may change to H2CheckoutIsClosed error so that the retry mechanism can be done outside. However, the same logic doesn't appear in the above case, so the retry mechanism can not be activated anymore if the checkout is closed.
I'm not sure which error message (checkout error/connecting error) is more proper to be raised, and it seems not so important.