test(server): fix flaky disable_keep_alive_mid_request #4009
+35
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This test would make use of the OS TCP stack, and sometimes on Mac of Windows, it would fail. The change switches to an in-memory transport, since the purpose is to test the timing on hyper's side, not the TCP stack. Closes #3949
seanmonstar
force-pushed
the
sean/flaky-test-keepalive-mid-request
branch
from
c3a4dbd to
f40443d
Compare
cratelyn
approved these changes
Jan 12, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test would make use of the OS TCP stack, and sometimes on Mac of Windows, it would fail.
The change switches to an in-memory transport, since the purpose is to test the timing on hyper's side, not the TCP stack.
Closes #3949