-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
tests(hyper): Add tests to increase coverage #510
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thanks for contributing! Unfortunately, I'm here to tell you there were the following style issues with your Pull Request:
Guidelines are available at https://github.com/hyperium/hyper/blob/master/CONTRIBUTING.md This message was auto-generated by https://gitcop.com |
|
I'm skeptical that coveralls and/or kcov is correctly reporting coverage, but certainly, more tests are always good! |
src/header/common/connection.rs
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why the switch from f.write_str? No actual formatting is needed...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My mistake at merging.
|
@seanmonstar Yes I also doubt that kcov is working correctly. There are some files even missing in the report. But it reports what cases are not covered by the tests so I fix the reported cases. |
tests(hyper): Add tests to increase coverage
No description provided.