Skip to content

Conversation

@pyfisch
Copy link
Contributor

@pyfisch pyfisch commented May 6, 2015

No description provided.

@GitCop
Copy link

GitCop commented May 6, 2015

Thanks for contributing! Unfortunately, I'm here to tell you there were the following style issues with your Pull Request:

  • Commit: d2f0cea
    • Invalid type. Valid types are feat, fix, docs, style, refactor, perf, test, chore, revert

Guidelines are available at https://github.com/hyperium/hyper/blob/master/CONTRIBUTING.md


This message was auto-generated by https://gitcop.com

@coveralls
Copy link

Coverage Status

Coverage increased (+0.88%) to 85.18% when pulling 0091556 on pyfisch:increasecov into 7f5e038 on hyperium:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.88%) to 85.18% when pulling 0091556 on pyfisch:increasecov into 7f5e038 on hyperium:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.97%) to 85.27% when pulling d014dff on pyfisch:increasecov into 7f5e038 on hyperium:master.

@seanmonstar
Copy link
Member

I'm skeptical that coveralls and/or kcov is correctly reporting coverage, but certainly, more tests are always good!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why the switch from f.write_str? No actual formatting is needed...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My mistake at merging.

@pyfisch
Copy link
Contributor Author

pyfisch commented May 6, 2015

@seanmonstar Yes I also doubt that kcov is working correctly. There are some files even missing in the report. But it reports what cases are not covered by the tests so I fix the reported cases.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.96%) to 85.26% when pulling ff346f1 on pyfisch:increasecov into 7f5e038 on hyperium:master.

seanmonstar added a commit that referenced this pull request May 6, 2015
tests(hyper): Add tests to increase coverage
@seanmonstar seanmonstar merged commit 71b26df into hyperium:master May 6, 2015
@pyfisch pyfisch deleted the increasecov branch May 16, 2015 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants