feat(server): check Response headers for Connection: close in keep_alive loop #527
+94
−56
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/server/mod.rs
Outdated
Contributor
There was a problem hiding this comment.
This function is starting to get really long, can you split this (or other) sections into another fn?
…ive loop BREAKING CHANGE: Usage of Response.deconstruct() and construct() now use a &mut Headers, instead of the struct proper.
seanmonstar
force-pushed
the
server-keep-alive
branch
from
ae7e741 to
49b5b8f
Compare
Member
Author
|
@reem ok, refactored that function... |
Contributor
|
LGTM - do we care about the coveralls regression as a blocker? |
Member
Author
|
I don't, as I still find the coverage report confusing and inaccurate. |
seanmonstar
added a commit
that referenced
this pull request
May 13, 2015
feat(server): check Response headers for Connection: close in keep_alive loop
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE: Usage of Response.deconstruct() and construct() now use
a &mut Headers, instead of the struct proper.