Skip to content

Conversation

@winding-lines
Copy link
Contributor

Sean, nice meeting you at the launch meetup today!

I am not sure what you are looking for in issue #351, here is a first minimal attempt. Comments welcome :)

@GitCop
Copy link

GitCop commented May 16, 2015

Thanks for contributing! Unfortunately, I'm here to tell you there were the following style issues with your Pull Request:

  • Commit: b4f8ec4
    • Commits must be in the following format: %{type}(%{scope}): %{description}

Guidelines are available at https://github.com/hyperium/hyper/blob/master/CONTRIBUTING.md


This message was auto-generated by https://gitcop.com

Initial implementation of the default trait.
@coveralls
Copy link

Coverage Status

Coverage remained the same at 85.42% when pulling b4f8ec4 on winding-lines:master into e9dcf45 on hyperium:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 85.42% when pulling be041d9 on winding-lines:master into e9dcf45 on hyperium:master.

@seanmonstar
Copy link
Member

Yes, this seems like a reasonable default to me.

seanmonstar added a commit that referenced this pull request May 16, 2015
Issue 351: default trait for client
@seanmonstar seanmonstar merged commit 9912e38 into hyperium:master May 16, 2015
@winding-lines
Copy link
Contributor Author

Thanks Sean! Which other traits would work for Client? Do Copy/Send/Sync make sense?

@seanmonstar
Copy link
Member

Client can't be Copy: it has a Box<NetworkConnector>, are Box<T> is not Copy. Send and Sync aren't implemented like most traits.

@winding-lines
Copy link
Contributor Author

Thanks, do you want to close this issue then?

@seanmonstar
Copy link
Member

This is a pull request, it's already been merged :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants