-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
feat(ssl): redesign SSL usage #577
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
src/net.rs
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typo in with as wit
|
Nice catches, fixed. |
|
I like the new Server API, seems more easily extensible. |
BREAKING CHANGE: Server::https was changed to allow any implementation of Ssl. Server in general was also changed. HttpConnector no longer uses SSL; using HttpsConnector instead.
feat(ssl): redesign SSL usage
|
@seanmonstar give me a heads up before publishing a new version including these changes please. |
|
Sure. I'll bump the version to 0.6 as well, since it has breaking changes. On Sat, Jun 20, 2015, 7:02 PM Jonathan Reem notifications@github.com
|
|
I'm trying to update a project to the latest versions of its dependencies including |
|
I think I figured it out let client = Client::with_connector(
HttpsConnector::new(
Openssl {
context: Arc::new(
ssl_ctx // <- I create this now
)
}
)
)this factory method want's quite what I needed but enough to steer me in the right direction. Great work on pushing this library forward. |
Server::httpswas changed to allow any implementation ofSsl.Serverin general was also changed. This was to help the design ofSsl, and will also allow a future Pull Request to allow theServerto support anIteratordesign, and accepting single requests; generally just not requiring that aHandler(and its task pool) be used.HttpConnectorno longer uses SSL; useHttpsConnectorinstead. NOTE: ServoClientwill useDefaultConnector, which will beHttpsConnectorby default. If the openssl feature is disabled, it will beHttpConnector. Those usingClient::new()should be unaffected.cc #573 #131 #541 #575 @reem @retep998 @Manishearth