Skip to content

Conversation

@seanmonstar
Copy link
Member

  • Server::https was changed to allow any implementation of Ssl.
  • Server in general was also changed. This was to help the design of Ssl, and will also allow a future Pull Request to allow the Server to support an Iterator design, and accepting single requests; generally just not requiring that a Handler (and its task pool) be used.
  • HttpConnector no longer uses SSL; use HttpsConnector instead. NOTE: Servo
  • Client will use DefaultConnector, which will be HttpsConnector by default. If the openssl feature is disabled, it will be HttpConnector. Those using Client::new() should be unaffected.

cc #573 #131 #541 #575 @reem @retep998 @Manishearth

src/net.rs Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo in with as wit

@seanmonstar
Copy link
Member Author

Nice catches, fixed.

@reem
Copy link
Contributor

reem commented Jun 20, 2015

I like the new Server API, seems more easily extensible.

BREAKING CHANGE: Server::https was changed to allow any implementation
  of Ssl. Server in general was also changed. HttpConnector no longer
  uses SSL; using HttpsConnector instead.
seanmonstar added a commit that referenced this pull request Jun 21, 2015
feat(ssl): redesign SSL usage
@seanmonstar seanmonstar merged commit c3935d6 into master Jun 21, 2015
@seanmonstar seanmonstar deleted the ssl branch June 21, 2015 01:16
@reem
Copy link
Contributor

reem commented Jun 21, 2015

@seanmonstar give me a heads up before publishing a new version including these changes please.

@seanmonstar
Copy link
Member Author

Sure. I'll bump the version to 0.6 as well, since it has breaking changes.

On Sat, Jun 20, 2015, 7:02 PM Jonathan Reem notifications@github.com
wrote:

@seanmonstar https://github.com/seanmonstar give me a heads up before
publishing a new version including these changes please.


Reply to this email directly or view it on GitHub
#577 (comment).

@softprops
Copy link
Contributor

I'm trying to update a project to the latest versions of its dependencies including hyper but am running into an issue that I think was a breaking change in this pull. There used to exist a client.set_ssl_verifier which I used here. This method seems to have went away, but I can't find the current alternative. Does one exists in the latest release?

@softprops
Copy link
Contributor

I think I figured it out

let client = Client::with_connector(
  HttpsConnector::new(
    Openssl {
      context: Arc::new(
        ssl_ctx // <- I create this now
       )
    }
  )
)

this factory method want's quite what I needed but enough to steer me in the right direction.

Great work on pushing this library forward.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants