refactor(headers): improve Range header adherence to HTTP spec
#578
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've started working on
Content-Rangeheader and realized that my previous implementation ofRangeheader was wrong.RangeSpecsmake sense only for byte ranges and all custom range units can have arbitrary strings as their values.I've modified the code to reflect that, but there is one thing for which I need your feedback:
I've used
Range::Otherfor custom ranges, as it IMO matches more closely naming in the RFC (other-ranges-specifier). The thing is thatAccept-Rangesheader usesRangeUnit::Unregisteredfor the same purpose, so it would make sense to decide on one them and use it consistently.This is kinda a breaking change. However since the
Rangeheader was introduced only a week ago, I'm not sure, if I should mark it as such.