chore(site): edit GitHub links (#3210)#90
chore(site): edit GitHub links (#3210)#90seanmonstar merged 6 commits intohyperium:masterfrom isaaccloos:#3210-edit-on-github-links
Conversation
Populate a new page field 'hyper_path' for copied contrib files. Conditionally link back to hyper if a 'hyper_path' is present, otherwise continue to reference hyperium.github.io (relevant for all collections besides contrib).
|
Hey @isaaccloos, thanks for this! I'll need to get reacquainted with sed and jekyll to comment on the changes (even though it's just been a few months since I worked on this 😅). Before I do that I just wanted to mention that you should be able to run and test the workflow on your fork. |
|
Welp, I certainly felt the burn of blindly adapting a workflow to a separate solution 💀. Please let the grace of squash erase this debris 🧹.
This comment is absolutely fascinating to me. After poking around in my fork and searching online a bit I have yet to discover how I can tap into the included workflow items from the actions tab on GitHub. If you have any insight I'd be excited to learn something new 🚀 |
|
You may have to work on main (master) for the workflows to run, that's what I did. There are also some settings for actions under |
|
Thanks for the support! Sadly, I believe I was experiencing a bug, or perhaps a nuance of GitHub that I still don't understand 🤪. After some head scratching I gave the default branch a love tap commit and 💥 the CI showed up and is available for all branches. This is just conjecture, but I'm leaning toward my usage of GitHub cli for creating forks as the root of this issue. I have done a few other tests using the website interface to create forks and the workflows were visible no problem. Curious indeed. I'm excited to improve my methodology in this way 😄 Should be particularly useful for hyperium/hyper#3099 |
|
Thanks so much for jumping on this! Does your recent comment suggest you've seen it working now? |
A bit of a nitpick, but I believe this change will make the process more fault tolerant moving forward.
|
I believe I am seeing good results from these changes. I have put together a collection of resources to demonstrate their effects1.
Footnotes |
seanmonstar
left a comment
There was a problem hiding this comment.
Stupendous work, thank you!
I greatly appreciate your attitude and willingness to fully explain out what you've tried, it makes reviewing a joy.

Overview
Populate a new page field 'hyper_path' for copied contrib files. Conditionally link back to hyper if a 'hyper_path' is present, otherwise continue to reference hyperium.github.io (relevant for all collections besides contrib).
Addresses hyperium/hyper#3210
Thought process
There are several interesting manipulations that happen within contrib.yml. These new additions should account for files that are:
Testing
I've been testing these changes in remote containers, but I'm interested to verify with the real workflow 🧪 🔬
Criticism Welcome 😄
I thrive on feedback, please let me know if you'd like to see any changes to meet the criteria 👍🏻