Skip to content

fix(lb): use the first available address #2576

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dentiny wants to merge 1 commit into
base: master
Choose a base branch
from
+4 −1
Open

fix(lb): use the first available address #2576

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion grpc/src/client/load_balancing/pick_first.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,10 @@ impl LbPolicy for PickFirstPolicy {
.ok_or("no endpoints")?
.addresses;

let address = addresses.pop().ok_or("no addresses")?;
if addresses.is_empty() {
return Err("no addresses".to_string());
}
let address = addresses.remove(0);

let sc = channel_controller.new_subchannel(&address);
sc.connect();
Expand Down
Loading