fix authority normalization#7
Conversation
jdesrosiers
left a comment
There was a problem hiding this comment.
Oops, I approved and then realized that there are no tests. Please add a test or two showing the intended behavior.
Hey @jdesrosiers i was wondering where should i place the test....should i place it in |
|
Yeah, |
jdesrosiers
left a comment
There was a problem hiding this comment.
No, just add to the list of resolution tests. Notice the last five tests are all testing normalization. Do something like that.
my bad, I've removed the standalone test and added it to the |
Description
The normalization process was lowercasing the entire authority component, which incorrectly lowercased the userinfo part.
FIXES : #5
Changes
resolveReferenceto copyuserinfo,host, andportwhen the base authority is used.composeIdentifierto build the authority string from components, lowercasing only the host.