This repository was archived by the owner on Mar 8, 2020. It is now read-only.
enable addition of README file via AddFile #1197
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidkel
pushed a commit
that referenced
this pull request
Jun 8, 2017
commit da75a0e Author: Nick Lincoln <nkl199@yahoo.co.uk> Date: Thu Jun 8 14:57:30 2017 +0100 change URL to match desired local build page (#1216) commit 712dc8b Author: Nick Lincoln <nkl199@yahoo.co.uk> Date: Thu Jun 8 14:00:46 2017 +0100 ensure setCurrent set on new models names (#1215) commit 0cd282c Author: Daniel Selman <danscode@selman.org> Date: Thu Jun 8 13:04:14 2017 +0100 Fixed broken links in docs (#1213) commit 372f3c6 Author: Nick Lincoln <nkl199@yahoo.co.uk> Date: Thu Jun 8 11:54:09 2017 +0100 condition for no filename on model file (#1212) commit eee22a5 Author: Matthew B White <mbwhite@users.noreply.github.com> Date: Thu Jun 8 10:05:44 2017 +0100 Defect unstable realy unstable (#1207) * add in the unstable tag * confirm installers commit 65c71b2 Author: Simon Stone <sstone1@uk.ibm.com> Date: Wed Jun 7 23:27:08 2017 +0100 BNAs are different during unit tests due to timestamps (#1201) * BNAs are different during unit tests due to timestamps * Remove incorrectly checked in console.log commit 4779f58 Author: Simon Stone <sstone1@uk.ibm.com> Date: Wed Jun 7 19:45:17 2017 +0100 Use the HLF connection profile by default for single line installer (#1200) commit d74e1c8 Author: Nick Lincoln <nkl199@yahoo.co.uk> Date: Wed Jun 7 15:29:52 2017 +0100 enable addition of README file via AddFile (#1197) * enable addition of README file via AddFile * add playground manual test reqs Signed-off-by: Dave Kelsey <d_kelsey@uk.ibm.com>
ghost
pushed a commit
that referenced
this pull request
Jun 12, 2017
* Added unit tests for add file component * Finished add-file component test and edit import to clear stubs * Bumped up about.service code coverage * Fixed minor linting issues * Removed fdescribe * Increase code coverage of add-file to 100% * Export AssetRegistry and ParticipantRegistry * Registry unit tests * First trasaction component test * Transaction component unit tests * Remove fdiscribe * Added resource unit tests * Github components unit tests * Added test file * Business network yeoman generator * Clean up template and give transaction template the correct name * Added missing semi colon * Added docs about skeleton business network generator * Added newlines to docs to stop md parse issues * Stop parser accepting floats as string defaults and ranges, and vice versa for ranges * Added option to allow create of models only * Fixed truncation of large data when pressing 'Show All' * Fixed business network generator issue #668 * Slight imporovement to deploy error message * Added checks and tests to solve issue #240 * Improved code efficiency and robustness * Change to open error modal if import fails * Fixed issue #792 docs problem * Added event support to base and web runtime * Rebrand cli readme * Web runtime events * HLFv1 can now emit events * GO event hub changes * merge commit * Events given numbers * Stop subscribing to events multiple times * Latest events * Unit tests for events * Duktape version fix * hlf0.6 event support * Logging updates * Added systests for events * enable couchdb in systemtest * Fixed systests * System and unit test fixes * rich query support for fabric V1 alpha * Removed test program * Removed conflict * fix query usage * Alpha 2 Support Signed-off-by: Dave Kelsey <d_kelsey@uk.ibm.com> * left a .only in Signed-off-by: Dave Kelsey <d_kelsey@uk.ibm.com> * add systest for rich query test * update query test script * enable couchdb in systemtest * rich query support for fabric V1 alpha * fix query usage * Merges * Fixed docker-compose.yml * update queryservice * add embedded queryservice * Merge with the latest master branch * wallet support, verfication support, tls support Signed-off-by: Dave Kelsey <d_kelsey@uk.ibm.com> * Squashed commit of the following: commit da75a0e Author: Nick Lincoln <nkl199@yahoo.co.uk> Date: Thu Jun 8 14:57:30 2017 +0100 change URL to match desired local build page (#1216) commit 712dc8b Author: Nick Lincoln <nkl199@yahoo.co.uk> Date: Thu Jun 8 14:00:46 2017 +0100 ensure setCurrent set on new models names (#1215) commit 0cd282c Author: Daniel Selman <danscode@selman.org> Date: Thu Jun 8 13:04:14 2017 +0100 Fixed broken links in docs (#1213) commit 372f3c6 Author: Nick Lincoln <nkl199@yahoo.co.uk> Date: Thu Jun 8 11:54:09 2017 +0100 condition for no filename on model file (#1212) commit eee22a5 Author: Matthew B White <mbwhite@users.noreply.github.com> Date: Thu Jun 8 10:05:44 2017 +0100 Defect unstable realy unstable (#1207) * add in the unstable tag * confirm installers commit 65c71b2 Author: Simon Stone <sstone1@uk.ibm.com> Date: Wed Jun 7 23:27:08 2017 +0100 BNAs are different during unit tests due to timestamps (#1201) * BNAs are different during unit tests due to timestamps * Remove incorrectly checked in console.log commit 4779f58 Author: Simon Stone <sstone1@uk.ibm.com> Date: Wed Jun 7 19:45:17 2017 +0100 Use the HLF connection profile by default for single line installer (#1200) commit d74e1c8 Author: Nick Lincoln <nkl199@yahoo.co.uk> Date: Wed Jun 7 15:29:52 2017 +0100 enable addition of README file via AddFile (#1197) * enable addition of README file via AddFile * add playground manual test reqs Signed-off-by: Dave Kelsey <d_kelsey@uk.ibm.com> * correct package.json to point to working npm modules Signed-off-by: Dave Kelsey <d_kelsey@uk.ibm.com> * restore lost code Signed-off-by: Dave Kelsey <d_kelsey@uk.ibm.com> * Fabric beta released Signed-off-by: Dave Kelsey <d_kelsey@uk.ibm.com> * removed merge conflict line Signed-off-by: Dave Kelsey <d_kelsey@uk.ibm.com> * peer review changes plus own code review changes Signed-off-by: Dave Kelsey <d_kelsey@uk.ibm.com> * removed commented out code Signed-off-by: Dave Kelsey <d_kelsey@uk.ibm.com> * cleanup of one click installer Signed-off-by: Dave Kelsey <d_kelsey@uk.ibm.com> * docker compose yaml was using tls Signed-off-by: Dave Kelsey <d_kelsey@uk.ibm.com> * revert change to identityservice.go it didn’t work Signed-off-by: Dave Kelsey <d_kelsey@uk.ibm.com> * fixed identity service Signed-off-by: Dave Kelsey <d_kelsey@uk.ibm.com> * save the query test updates * save the query test updates
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Final aspect of #387
Design of the fix
Validation of the fix
manual validation on local build & test addition
Automated Tests
tests extended