Skip to content
This repository was archived by the owner on Jan 22, 2020. It is now read-only.

Conversation

@alexandrag2254
Copy link
Contributor

Signed-off-by: Alexandra Groetsema alexandrag2254@gmail.com

Signed-off-by: Alexandra Groetsema <alexandrag2254@gmail.com>
@alexandrag2254 alexandrag2254 requested a review from tkuhrt October 23, 2017 05:38
@@ -0,0 +1,103 @@
<!DOCTYPE html>
<html>
Copy link
Contributor

@tkuhrt tkuhrt Oct 23, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add a comment to this file to specify the license using SPDX short identifiers?
<!-- SPDX-License-Identifier: Apache-2.0 -->

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure! At the very top? Good to add this comment to the Fabric index.html page as well?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, we definitely want this on the Fabric work too.

},
"repository": {
"type": "git",
"url": "git+https://github.com/hyperledger/LFS171x/sawtooth-material/sawtooth-tuna.git"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is missing the education folder. Also, probably needs to be: https://github.com/hyperledger/education.git

@@ -0,0 +1,110 @@
'use strict'
Copy link
Contributor

@tkuhrt tkuhrt Oct 23, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Provide license information for this file.
// SPDX-License-Identifier: Apache-2.0

@@ -0,0 +1,30 @@
'use strict'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Provide license information for this file.
// SPDX-License-Identifier: Apache-2.0

@@ -0,0 +1,91 @@
'use strict'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Provide license information for this file.
// SPDX-License-Identifier: Apache-2.0

@@ -0,0 +1,9 @@
const path = require('path')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Provide license information for this file.
// SPDX-License-Identifier: Apache-2.0

@@ -0,0 +1,140 @@
'use strict'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Provide license information for this file.
// SPDX-License-Identifier: Apache-2.0

@@ -0,0 +1,11 @@
'use strict'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Provide license information for this file.
// SPDX-License-Identifier: Apache-2.0

Signed-off-by: Alexandra Groetsema <alexandrag2254@gmail.com>
Copy link
Contributor

@tkuhrt tkuhrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tkuhrt tkuhrt merged commit 1ddf5d5 into master Oct 23, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants