-
Notifications
You must be signed in to change notification settings - Fork 356
adding LFS171x sawtooth code to education folder #6
Conversation
Signed-off-by: Alexandra Groetsema <alexandrag2254@gmail.com>
| @@ -0,0 +1,103 @@ | |||
| <!DOCTYPE html> | |||
| <html> | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we add a comment to this file to specify the license using SPDX short identifiers?
<!-- SPDX-License-Identifier: Apache-2.0 -->
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure! At the very top? Good to add this comment to the Fabric index.html page as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, we definitely want this on the Fabric work too.
| }, | ||
| "repository": { | ||
| "type": "git", | ||
| "url": "git+https://github.com/hyperledger/LFS171x/sawtooth-material/sawtooth-tuna.git" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is missing the education folder. Also, probably needs to be: https://github.com/hyperledger/education.git
| @@ -0,0 +1,110 @@ | |||
| 'use strict' | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Provide license information for this file.
// SPDX-License-Identifier: Apache-2.0
| @@ -0,0 +1,30 @@ | |||
| 'use strict' | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Provide license information for this file.
// SPDX-License-Identifier: Apache-2.0
| @@ -0,0 +1,91 @@ | |||
| 'use strict' | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Provide license information for this file.
// SPDX-License-Identifier: Apache-2.0
| @@ -0,0 +1,9 @@ | |||
| const path = require('path') | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Provide license information for this file.
// SPDX-License-Identifier: Apache-2.0
| @@ -0,0 +1,140 @@ | |||
| 'use strict' | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Provide license information for this file.
// SPDX-License-Identifier: Apache-2.0
| @@ -0,0 +1,11 @@ | |||
| 'use strict' | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Provide license information for this file.
// SPDX-License-Identifier: Apache-2.0
Signed-off-by: Alexandra Groetsema <alexandrag2254@gmail.com>
tkuhrt
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: Alexandra Groetsema alexandrag2254@gmail.com