Skip to content

Conversation

@elribonazo
Copy link
Contributor

@elribonazo elribonazo commented Feb 19, 2025

Description:

Fixing JWK implementation, converting it to a Pollux task and making it work for EC and OKP types.

Checklist:

  • My PR follows the contribution guidelines of this project
  • My PR is free of third-party dependencies that don't comply with the Allowlist
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked the PR title to follow the conventional commit specification

@elribonazo elribonazo linked an issue Feb 19, 2025 that may be closed by this pull request
@coveralls
Copy link

coveralls commented Feb 19, 2025

Pull Request Test Coverage Report for Build 13764766187

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 110 of 122 (90.16%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.4%) to 74.467%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/pollux/utils/jwt/FromJWK.ts 50 52 96.15%
src/apollo/Apollo.ts 59 64 92.19%
src/pollux/utils/jwt/PKInstance.ts 1 6 16.67%
Totals Coverage Status
Change from base Build 13676367895: 0.4%
Covered Lines: 3394
Relevant Lines: 4344

💛 - Coveralls

@elribonazo elribonazo marked this pull request as ready for review February 19, 2025 13:20
@elribonazo elribonazo requested a review from a team as a code owner March 5, 2025 12:23
@elribonazo elribonazo requested a review from curtis-h March 5, 2025 12:24
Signed-off-by: Francisco Javier Ribo Labrador <elribonazo@gmail.com>
Signed-off-by: Francisco Javier Ribo Labrador <elribonazo@gmail.com>
Signed-off-by: Francisco Javier Ribo Labrador <elribonazo@gmail.com>
Signed-off-by: Francisco Javier Ribo Labrador <elribonazo@gmail.com>
Signed-off-by: Francisco Javier Ribo Labrador <elribonazo@gmail.com>
Signed-off-by: Francisco Javier Ribo Labrador <elribonazo@gmail.com>
Signed-off-by: Francisco Javier Ribo Labrador <elribonazo@gmail.com>
Signed-off-by: Francisco Javier Ribo Labrador <elribonazo@gmail.com>
Signed-off-by: Francisco Javier Ribo Labrador <elribonazo@gmail.com>
Signed-off-by: Francisco Javier Ribo Labrador <elribonazo@gmail.com>
@elribonazo elribonazo force-pushed the 369-improve-jwk-into-publickey-conversions branch from c0c8a28 to 32e5d56 Compare March 6, 2025 15:48
…pk creation from curvePoints with Secp256K1, but pollux shouldn't care about it and send whatever it has

Signed-off-by: Francisco Javier Ribo Labrador <elribonazo@gmail.com>
@elribonazo elribonazo merged commit b0f742b into main Mar 10, 2025
6 checks passed
@elribonazo elribonazo deleted the 369-improve-jwk-into-publickey-conversions branch March 10, 2025 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Improve JWK into PublicKey conversions

4 participants