Skip to content

fix: improve types #448

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
elribonazo merged 2 commits into from
Jul 9, 2025
Merged

fix: improve types #448

elribonazo merged 2 commits into from
Jul 9, 2025

Conversation

@elribonazo
Copy link
Contributor

@elribonazo elribonazo commented Jul 9, 2025 •
edited
Loading

Description:

Simple task to allow typescript to infer whatever is the response type when calling task plugins

Checklist:

  • My PR follows the contribution guidelines of this project
  • My PR is free of third-party dependencies that don't comply with the Allowlist
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked the PR title to follow the conventional commit specification

@elribonazo elribonazo requested a review from a team as a code owner July 9, 2025 10:34
@elribonazo elribonazo linked an issue Jul 9, 2025 that may be closed by this pull request
Plugin Tasks issue with response payload type inference #447
Closed
@elribonazo
fix: improve types
6789da1 
Signed-off-by: Francisco Javier Ribo Labrador <elribonazo@gmail.com>
@elribonazo elribonazo force-pushed the 447-plugin-tasks-issue-with-response-payload-type-inference branch from 6c91bd0 to 6789da1 Compare July 9, 2025 10:34
@elribonazo
fix: type issue
518bec7 
Signed-off-by: Francisco Javier Ribo Labrador <elribonazo@gmail.com>
@elribonazo elribonazo enabled auto-merge (squash) July 9, 2025 10:51
@coveralls
Copy link

coveralls commented Jul 9, 2025

Coverage Status

coverage: 72.405%. remained the same
when pulling 518bec7 on 447-plugin-tasks-issue-with-response-payload-type-inference
into b30b6e9 on main.

@elribonazo elribonazo merged commit 3b35504 into main Jul 9, 2025
8 checks passed
@elribonazo elribonazo deleted the 447-plugin-tasks-issue-with-response-payload-type-inference branch July 9, 2025 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mineme0110 mineme0110 mineme0110 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Plugin Tasks issue with response payload type inference

4 participants

@elribonazo @coveralls @mineme0110