Example: Added Comments for Iroha Documentation #68
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sara <lira.lemur@gmail.com>
kuvaldini
approved these changes
Mar 25, 2021
kuvaldini
approved these changes
Mar 25, 2021
igor-egorov
approved these changes
Mar 27, 2021
stepanLav
pushed a commit
to stepanLav/iroha-python
that referenced
this pull request
Jul 6, 2021
Signed-off-by: Sara <lira.lemur@gmail.com> Signed-off-by: Stepan Lavrentev <lawrentievsv@gmail.com>
stepanLav
added a commit
to stepanLav/iroha-python
that referenced
this pull request
Jul 9, 2021
commit 92d8177 Author: Stepan Lavrentev <40560660+stepanLav@users.noreply.github.com> Date: Thu Jul 8 08:31:43 2021 +0300 Add ability to provide custom TLS cert (hyperledger-iroha#63) Signed-off-by: Stepan Lavrentev <lawrentievsv@gmail.com> commit 4d10eb0 Author: Grzegorz Bazior <g.bazior@yodiss.pl> Date: Fri Apr 23 18:02:10 2021 +0200 Add possibility of checking transaction status by hash Signed-off-by: Grzegorz Bazior <g.bazior@yodiss.pl> commit c0a53ef Author: Sara <lira.lemur@gmail.com> Date: Tue Mar 30 01:38:39 2021 +0300 added comments for iroha docs (hyperledger-iroha#68) Signed-off-by: Sara <lira.lemur@gmail.com> commit 3968c39 Author: Grzegorz Bazior <g.bazior@yodiss.pl> Date: Thu Mar 11 23:18:44 2021 +0100 Add optional argument to configure GRPC max message length Signed-off-by: Grzegorz Bazior <g.bazior@yodiss.pl> commit 293d682 Author: Ry Jones <ry@linux.com> Date: Thu Mar 25 12:25:13 2021 -0700 Update repolinter.yml Signed-off-by: Ry Jones <ry@linux.com> commit 7955e40 Author: Ry Jones <ry@linux.com> Date: Mon Mar 22 17:40:11 2021 -0700 Catch repolinter errors Signed-off-by: Ry Jones <ry@linux.com> commit ed38676 Author: Ry Jones <ry@linux.com> Date: Mon Mar 22 12:56:01 2021 -0700 Create repolinter.yml Signed-off-by: Ry Jones <ry@linux.com> commit c0c7797 Merge: 70e0e96 9470329 Author: Andrei Lebedev <lebdron@gmail.com> Date: Mon Dec 7 18:49:25 2020 +0100 Merge pull request hyperledger-iroha#64 from vadimreutskiy/master Fix dependencies for the package setup commit 9470329 Author: Vadim Reutskiy <reutskiy.vadim@gmail.com> Date: Tue Dec 1 21:27:19 2020 +0900 Fix dependencies for the package setup Signed-off-by: Vadim Reutskiy <reutskiy.vadim@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Sara lira.lemur@gmail.com
Previously there was a page with step-by step description of the example that was actually changing: https://iroha.readthedocs.io/en/master/getting_started/python-guide.html and it is not working - neither conceptually as pieces of code nor de facto as the code is outdated.
So it was decided to simply include the actual example code there and just move the comments to the example itself. And here we go!
Also see hyperledger-iroha/iroha#895
Small drawback: when we move to main from master the include will have to be fixed.