htlc auditing extension #369
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HagarMeir
reviewed
Sep 18, 2022
| if !output.IsHTLC() { | ||
| continue | ||
| } | ||
| // check script details, for example make sure the deadline has not passed |
Contributor
There was a problem hiding this comment.
AcceptCashView is only used to accept when there is an issue (according to latest topology) and so this code is never used.
Contributor
Author
There was a problem hiding this comment.
aha, good catch. It is during Lock. We have already stuff there. I will update.
HagarMeir
reviewed
Sep 18, 2022
| } | ||
| // check script details, for example make sure the deadline has not passed | ||
| script, err := output.Script() | ||
| assert.NoError(err, "cannot get htlc script from input") |
HagarMeir
reviewed
Sep 18, 2022
| if !output.IsHTLC() { | ||
| continue | ||
| } | ||
| // check script details, for example make sure the deadline has not passed |
Contributor
There was a problem hiding this comment.
script.Validate checks more than just the deadline
HagarMeir
reviewed
Sep 18, 2022
| "time" | ||
|
|
||
| "github.com/pkg/errors" | ||
|
|
Contributor
There was a problem hiding this comment.
please remove empty line and run go imports
HagarMeir
reviewed
Sep 18, 2022
token/services/interop/htlc/audit.go
Outdated
| script := &Script{} | ||
| err = json.Unmarshal(owner.Identity, script) | ||
| if err != nil { | ||
| return nil, err |
Contributor
There was a problem hiding this comment.
maybe add a description to this error
HagarMeir
reviewed
Sep 18, 2022
token/services/interop/htlc/audit.go
Outdated
| script := &Script{} | ||
| err = json.Unmarshal(owner.Identity, script) | ||
| if err != nil { | ||
| return nil, err |
Contributor
There was a problem hiding this comment.
maybe add a description to this error
HagarMeir
reviewed
Sep 18, 2022
| // - The recipient must be set | ||
| // - The deadline must be after the passed time reference | ||
| // - HashInfo must be Available | ||
| func (s Script) Validate(timeReference time.Time) error { |
Signed-off-by: Angelo De Caro <adc@zurich.ibm.com>
Signed-off-by: Angelo De Caro <adc@zurich.ibm.com>
Signed-off-by: Hagar Meir <hagar.meir@ibm.com>
Signed-off-by: Hagar Meir <hagar.meir@ibm.com>
Signed-off-by: Hagar Meir <hagar.meir@ibm.com>
- finalizing integration test checks Signed-off-by: Angelo De Caro <adc@zurich.ibm.com>
…izing integration test checks Signed-off-by: Angelo De Caro <adc@zurich.ibm.com>
…izing integration test checks Signed-off-by: Angelo De Caro <adc@zurich.ibm.com>
…izing integration test checks Signed-off-by: Angelo De Caro <adc@zurich.ibm.com>
adecaro
force-pushed
the
f-audit-ext
branch
from
13384b6 to
9bae016
Compare
HagarMeir
approved these changes
Sep 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces the following capabilities:
As a bonus, this PR also improves on the validation of the HTLC script.
Signed-off-by: Angelo De Caro adc@zurich.ibm.com