doc --rpc-http-max-active-connections option #638
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alexandra Tran <alexandra.tran@consensys.net>
Signed-off-by: Alexandra Tran <alexandra.tran@consensys.net>
bgravenorst
reviewed
Mar 17, 2021
docs/Reference/CLI/CLI-Syntax.md
Outdated
| rpc-http-max-active-connections="100" | ||
| ``` | ||
|
|
||
| The maximum number of HTTP connections allowed for JSON-RPC. Once this limit is reached, incoming connections will be rejected. The default is 80. |
Contributor
There was a problem hiding this comment.
Minor suggestions:
"The maximum number of allowed HTTP JSON-RPC connections."
Try and rephrase without "will". It's one of the words on our do not use list :)
bgravenorst
requested changes
Mar 17, 2021
Contributor
bgravenorst
left a comment
bgravenorst
left a comment
There was a problem hiding this comment.
Minor suggestions. Also, similar to the other issue I'm not sure quotes ("") are required around integers in the config file. But we seem pretty inconsistent in the docs.
docs/Reference/CLI/CLI-Syntax.md
Outdated
| === "Configuration File" | ||
|
|
||
| ```bash | ||
| rpc-http-max-active-connections="100" |
Contributor
There was a problem hiding this comment.
the TOML syntax for integers is indeed without quotes, see https://toml.io/en/
Signed-off-by: Nicolas MASSART <nicolas.massart@consensys.net>
NicolasMassart
force-pushed
the
630_doc_rpc_http_max_active_connections
branch
from
d6fd8e3 to
ef06f98
Compare
Signed-off-by: Alexandra Tran <alexandra.tran@consensys.net>
…alexandratran/besu-docs into 630_doc_rpc_http_max_active_connections Signed-off-by: Alexandra Tran <alexandra.tran@consensys.net> # Conflicts: # docs/Reference/CLI/CLI-Syntax.md
NicolasMassart
approved these changes
Mar 18, 2021
|
Hi How many max rpc connection able to set in the node. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
Use the following list to make sure your PR fits the Besu doc quality standard.
Before creating the pull request
Make sure that:
After creating your pull request and tests finished
Make sure that:
and updated the testing link (see Testing).
Describe the change
Add documentation for the --rpc-http-max-active-connection option
Issue fixed
fixes #630
Impacted parts
For content changes
For tools changes
Testing
https://hyperledger-besu--638.org.readthedocs.build/en/638/
Screenshots / recording