[BESU-1919] Add proper support for eth_hashrate #1063
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Karim TAAM <karim.t2am@gmail.com>
Signed-off-by: Karim TAAM <karim.t2am@gmail.com>
Signed-off-by: Karim TAAM <karim.t2am@gmail.com>
matkt
added
the
doc-change-required
Signed-off-by: Karim TAAM <karim.t2am@gmail.com>
Signed-off-by: Karim TAAM <karim.t2am@gmail.com>
Signed-off-by: Karim TAAM <karim.t2am@gmail.com>
Signed-off-by: Karim TAAM <karim.t2am@gmail.com>
Signed-off-by: Karim TAAM <karim.t2am@gmail.com>
shemnon
reviewed
Jun 11, 2020
Contributor
shemnon
left a comment
shemnon
left a comment
There was a problem hiding this comment.
I think we need to move the hashrate logic out of the AbstractMiningCoordinator into EthashMiningCoordinator and not expose the SealerInfo map and instead expose the aggregate hashrate.
...ion/src/main/java/org/hyperledger/besu/ethereum/blockcreation/AbstractMiningCoordinator.java
Outdated
Show resolved
Hide resolved
| final BlockHeader newChainHeadHeader); | ||
|
|
||
| @Override | ||
| public Map<String, SealerInfo> getSealerInfos() { |
Contributor
There was a problem hiding this comment.
I think it would be better to move all the logic around submitting hashrate and storing the sealerInfo down into the EthashMiningCoordinator. IBFT and Clique will never use these.
...ockcreation/src/main/java/org/hyperledger/besu/ethereum/blockcreation/MiningCoordinator.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Karim TAAM <karim.t2am@gmail.com>
Signed-off-by: Karim TAAM <karim.t2am@gmail.com>
Signed-off-by: Karim TAAM <karim.t2am@gmail.com>
Signed-off-by: Karim TAAM <karim.t2am@gmail.com>
Signed-off-by: Karim TAAM <karim.t2am@gmail.com>
Signed-off-by: Karim TAAM <karim.t2am@gmail.com>
shemnon
approved these changes
Jun 15, 2020
Signed-off-by: Karim TAAM <karim.t2am@gmail.com>
Contributor
|
Raised hyperledger/besu-docs#414 to doc this so this can be closed. |
bgravenorst
removed
the
doc-change-required
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
submitHashrateendpoint which is by default limited to 1000 sealers. Adding a 1001 will remove the oldest from the list (0x0 hashrate is refused)eth_hashrateendpoint so that it returns the cumulative hashrate of all sealers if the list is not empty. Otherwise it returns the local hashrateStratum1EthProxyProtocolandStratum1ProtocolTested