[BESU-696/492][Fix the eth_estimateGas json rpc

[matkt]

Signed-off-by: Karim TAAM karim.t2am@gmail.com

PR description

Fix cases where the gas estimate is too low and causes the transaction to fail

Implementation of a strategy that will estimate the number of gas needed by a transaction

1 - Estimate the number of gas used by a transaction
2 - Estimate the number of gas necessary to add for each sub call present in a transaction (65/64^depth)
3 - Add the minimum gas required for operations that need it (SSTORE) https://eips.ethereum.org/EIPS/eip-1706

This has been tested with the test network (dev) and the Clique network.

[RatanRSur]

Is the current version failing to give a high enough estimate in a case other than this?

See eth_call parameters, expect that all properties are optional. If no gas limit is specified geth uses the block gas limit from the pending block as an upper bound. As a result the returned estimate might not be enough to executed the call/transaction when the amount of gas is higher than the pending block gas limit.

https://github.com/ethereum/wiki/wiki/JSON-RPC#eth_estimategas

[matkt]

Is the current version failing to give a high enough estimate in a case other than this?

See eth_call parameters, expect that all properties are optional. If no gas limit is specified geth uses the block gas limit from the pending block as an upper bound. As a result the returned estimate might not be enough to executed the call/transaction when the amount of gas is higher than the pending block gas limit.

https://github.com/ethereum/wiki/wiki/JSON-RPC#eth_estimategas

My quick reading

Yes in some cases the estimate was not good despite a sufficient block gas limit. A good test is present and allows you to see the different behavior with Geth (https://github.com/cianx/besu-test). For example in the case of resetting the balance to 0. In the test presented above the block gas limit is "0x1fffffffffffff"

[AbdelStark]

Some changes need to be addressed.