This repository was archived by the owner on Apr 22, 2025. It is now read-only.
force immediate shutdown of the network connection #153
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bestbeforetoday
suggested changes
Mar 31, 2023
There was a problem hiding this comment.
This change looks good. Thank you for the contribution! Two minor issues to address:
- The commit message needs a Signed-off-by trailer to satisfy the Linux Foundation's Developer Certificate or Origin. You should be able to amend your commit to add the sign-off with
git commit --amend --signoff, thengit push --force-with-leasethe amended commit to your PR branch. - I think it is worth changing the unit tests slightly to confirm the behaviour you have implemented. See in-line comments and code suggestion.
Signed-off-by: yoshiteru imamura <yoshiteru-imamura@kccs.co.jp>
yoshiteru-imamura
force-pushed
the
forceclose
branch
from
4ecf813 to
8405826
Compare
Signed-off-by: yoshiteru imamura <yoshiteru-imamura@kccs.co.jp>
bestbeforetoday
approved these changes
Apr 4, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolve #87