This repository was archived by the owner on Apr 22, 2025. It is now read-only.
[FABJ-534] Use Bouncy Castle to generate private keys#79
Merged
andrew-coleman merged 1 commit intohyperledger:release-2.2from Aug 20, 2020
Merged
[FABJ-534] Use Bouncy Castle to generate private keys#79andrew-coleman merged 1 commit intohyperledger:release-2.2from
andrew-coleman merged 1 commit intohyperledger:release-2.2from
Conversation
Use Bouncy Castle to generate private keys when we are generating a self signed certificate to use for service discovery when mutual TLS is disabled. This works more reliably then just using the default security provider. Also, use Bouncy Castle classes to serialize the private key into the PEM format instead of the hand written code. Signed-off-by: Simon Stone <sstone1@uk.ibm.com>
andrew-coleman
approved these changes
Aug 20, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use Bouncy Castle to generate private keys when we are
generating a self signed certificate to use for service
discovery when mutual TLS is disabled. This works more
reliably then just using the default security provider.
Also, use Bouncy Castle classes to serialize the private
key into the PEM format instead of the hand written code.
Signed-off-by: Simon Stone sstone1@uk.ibm.com