add support WriteBatch operations

[pfi79]

#5086

[pfi79]

In the e2e integration tests, benchmark test has been added and 2 speed tables appear with and without the use of batch.

[C0rWin]

Overall looks good to me, while I think we should take care to add tests to make sure behaviour remain consistent as @manish-sethi mentioned is his comment hyperledger/fabric-rfcs#58 (comment)

[pfi79]

Overall looks good to me, while I think we should take care to add tests to make sure behaviour remain consistent as @manish-sethi mentioned is his comment hyperledger/fabric-rfcs#58 (comment)

Thanks @C0rWin
I'm willing to finish any tests.
But I'm not quite sure what those tests should be.
If they give me scenarios, I'd be happy to implement them.

[C0rWin]

Overall looks good to me, while I think we should take care to add tests to make sure behaviour remain consistent as @manish-sethi mentioned is his comment hyperledger/fabric-rfcs#58 (comment)

Thanks @C0rWin I'm willing to finish any tests. But I'm not quite sure what those tests should be. If they give me scenarios, I'd be happy to implement them.

One of the possible scenarios related to the update of the private data is where there is a check whenever a collection with a given name exists, see

fabric/core/ledger/kvledger/txmgmt/txmgr/tx_simulator.go

Line 105 in 6c2e87c

if err := s.queryExecutor.validateCollName(ns, coll); err != nil {

... The test should, for example, check what happens when you start batch where you are trying to write into the non-existing collection, without batch it's resulted with error, need to check this behavior is consistent.

Another example would be to check whenever chaincode does write into private data and then query private data it supposes to result in an error based on this check, see here:

fabric/core/ledger/kvledger/txmgmt/txmgr/tx_simulator.go

Line 234 in 6c2e87c

func (s *txSimulator) checkBeforePvtdataQueries() error {

[pfi79]

Overall looks good to me, while I think we should take care to add tests to make sure behaviour remain consistent as @manish-sethi mentioned is his comment hyperledger/fabric-rfcs#58 (comment)

Thanks @C0rWin I'm willing to finish any tests. But I'm not quite sure what those tests should be. If they give me scenarios, I'd be happy to implement them.

One of the possible scenarios related to the update of the private data is where there is a check whenever a collection with a given name exists, see

fabric/core/ledger/kvledger/txmgmt/txmgr/tx_simulator.go

Line 105 in 6c2e87c

if err := s.queryExecutor.validateCollName(ns, coll); err != nil {

... The test should, for example, check what happens when you start batch where you are trying to write into the non-existing collection, without batch it's resulted with error, need to check this behavior is consistent.
Another example would be to check whenever chaincode does write into private data and then query private data it supposes to result in an error based on this check, see here:

fabric/core/ledger/kvledger/txmgmt/txmgr/tx_simulator.go

Line 234 in 6c2e87c

func (s *txSimulator) checkBeforePvtdataQueries() error {

@C0rWin @denyeart
Added the right tests.
Please take a look at my proposal.

[denyeart]

LGTM