Skip to content

Firefly besu clique#118

Merged
nguyer merged 14 commits intohyperledger:mainfrom
sukrut29:firefly-besu-clique
Nov 9, 2021
Merged

Firefly besu clique#118
nguyer merged 14 commits intohyperledger:mainfrom
sukrut29:firefly-besu-clique

Conversation

@sukrut29
Copy link
Copy Markdown
Contributor

@sukrut29 sukrut29 commented Nov 3, 2021

"Signed-off-by: sukrut29 sukrut.sathaye@sttech.de"

Signed-off-by: sukrut29 <sukrut.sathaye@sttech.de>
Signed-off-by: sukrut29 <sukrut.sathaye@sttech.de>
Signed-off-by: sukrut29 <sukrut.sathaye@sttech.de>
…f nodes compared to IBFT2 hence, less load on device). Works now with hardcoded sleep before deploying contracts

Signed-off-by: sukrut29 <sukrut.sathaye@sttech.de>
@sukrut29 sukrut29 force-pushed the firefly-besu-clique branch from ddc3d04 to 7c98eb8 Compare November 3, 2021 13:31
… fully compiled binaries for ff without config file dependencies

Signed-off-by: sukrut29 <sukrut.sathaye@sttech.de>
Signed-off-by: sukrut29 <sukrut.sathaye@sttech.de>
Signed-off-by: sukrut29 <sukrut.sathaye@sttech.de>
Signed-off-by: sukrut29 <sukrut.sathaye@sttech.de>
… timed out waiting for transaction receipt error

Signed-off-by: sukrut29 <sukrut.sathaye@sttech.de>
…sfully

Signed-off-by: sukrut29 <sukrut.sathaye@sttech.de>
@nguyer
Copy link
Copy Markdown
Contributor

nguyer commented Nov 4, 2021

Sukrut and I chatted directly about this, but it looks like tokens functionality is not working correctly with this configuration. When I run the E2E tests against this stack, I see ethconnect not getting events from the blockchain for transactions submitted by the token connector, which is causing tests to fail right now. Some more investigation will be needed into why this is happening, but unfortunately I do not have the cycles at the moment to look into it.

@sukrut29
Copy link
Copy Markdown
Contributor Author

sukrut29 commented Nov 4, 2021

Sukrut and I chatted directly about this, but it looks like tokens functionality is not working correctly with this configuration. When I run the E2E tests against this stack, I see ethconnect not getting events from the blockchain for transactions submitted by the token connector, which is causing tests to fail right now. Some more investigation will be needed into why this is happening, but unfortunately I do not have the cycles at the moment to look into it.

Your reply is much appreciated. :)
Thank you for taking out the time to review and test. Whenever you have time, we can look into it next and get it sorted.

nguyer and others added 4 commits November 9, 2021 09:29
Signed-off-by: Nicko Guyer <nicko.guyer@kaleido.io>
Signed-off-by: Nicko Guyer <nicko.guyer@kaleido.io>
Signed-off-by: Nicko Guyer <nicko.guyer@kaleido.io>
Copy link
Copy Markdown
Contributor

@nguyer nguyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is really great! Thank you @sukrut29 for contributing this!

There may be some room for additional simplification of the Besu config directory, but I think we should merge this, and perhaps we can continue to refine it later.

Thanks again!

@nguyer nguyer merged commit 4c3f0fa into hyperledger:main Nov 9, 2021
@sukrut29
Copy link
Copy Markdown
Contributor Author

sukrut29 commented Nov 9, 2021

Thanks a lot for your support @nguyer and constant availability for communications :)
It was a pleasure to collaborate with you and contribute!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants