Skip to content

FireFly v0.13.0 is not specifying a name for subscriptions #554

@peterbroadhurst

Description

@peterbroadhurst

In this change:
98890dc

We moved to use the flat POST /subscriptions route on EthConnect, rather than requiring an ABI to be deployed to EthConnect first.

However, we seem to have missed specifying the name when we create it - so this check fails on every startup, and we're creating duplicate subscriptions for the same event:

for _, s := range existingSubs {
if s.Name == subName ||
/* Check for the plain name we used to use originally, before adding uniqueness qualifier.
If one of these very early environments needed a new subscription, the existing one would need to
be deleted manually. */
s.Name == abi.Name {
sub = s
}
}

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions