Skip to content

Conversation

@dechdev
Copy link
Contributor

@dechdev dechdev commented Aug 30, 2022

Tutorial to guide user through creating a Custom Identity in FireFly.

References #621

Signed-off-by: David Echelberger <eberger727@gmail.com>
Copy link
Contributor

@peterbroadhurst peterbroadhurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Think this is a great addition. Couple of requests - main one is that we should guide people to use the CLI I think for the signing key creation instructions, vs. Postman.

The Postman instructions are specific to CLI created environments anyway (they wouldn't work for example with a more sophisticated environment, such as a firefly-signer connection to a public chain, or a remote Kaleido blockchain etc.)

@dechdev
Copy link
Contributor Author

dechdev commented Sep 2, 2022

Thanks for the review @peterbroadhurst
Don't think I'll finish the changes before rc3 goes out, but will be ready by Tuesday

@codecov-commenter
Copy link

codecov-commenter commented Sep 4, 2022

Codecov Report

Merging #1022 (5e3a230) into main (75fc92d) will increase coverage by 0.15%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1022      +/-   ##
==========================================
+ Coverage   99.83%   99.99%   +0.15%     
==========================================
  Files         307      307              
  Lines       20264    20294      +30     
==========================================
+ Hits        20230    20292      +62     
+ Misses         19        2      -17     
+ Partials       15        0      -15     
Impacted Files Coverage Δ
internal/orchestrator/status.go 100.00% <0.00%> (ø)
internal/dataexchange/ffdx/ffdx.go 100.00% <0.00%> (ø)
internal/privatemessaging/recipients.go 100.00% <0.00%> (ø)
internal/blockchain/ethereum/ethereum.go 100.00% <0.00%> (+0.38%) ⬆️
internal/blockchain/fabric/fabric.go 100.00% <0.00%> (+0.39%) ⬆️
internal/events/aggregator.go 100.00% <0.00%> (+0.51%) ⬆️
internal/privatemessaging/privatemessaging.go 100.00% <0.00%> (+1.22%) ⬆️
internal/identity/identitymanager.go 100.00% <0.00%> (+1.26%) ⬆️
internal/operations/manager.go 100.00% <0.00%> (+1.38%) ⬆️
internal/data/data_manager.go 100.00% <0.00%> (+1.42%) ⬆️
... and 4 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

nguyer and others added 2 commits September 19, 2022 14:30
Signed-off-by: Nicko Guyer <nicko.guyer@kaleido.io>
Signed-off-by: David Echelberger <eberger727@gmail.com>
Copy link
Contributor

@peterbroadhurst peterbroadhurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks both for the updates to use the CLI.

@peterbroadhurst peterbroadhurst merged commit 854c075 into hyperledger:main Sep 20, 2022
@peterbroadhurst peterbroadhurst deleted the identity-tutorial branch September 20, 2022 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants