-
Notifications
You must be signed in to change notification settings - Fork 242
[identity-tutorial] identity tutorial #1022
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[identity-tutorial] identity tutorial #1022
Conversation
Signed-off-by: David Echelberger <eberger727@gmail.com>
peterbroadhurst
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Think this is a great addition. Couple of requests - main one is that we should guide people to use the CLI I think for the signing key creation instructions, vs. Postman.
The Postman instructions are specific to CLI created environments anyway (they wouldn't work for example with a more sophisticated environment, such as a firefly-signer connection to a public chain, or a remote Kaleido blockchain etc.)
|
Thanks for the review @peterbroadhurst |
Codecov Report
@@ Coverage Diff @@
## main #1022 +/- ##
==========================================
+ Coverage 99.83% 99.99% +0.15%
==========================================
Files 307 307
Lines 20264 20294 +30
==========================================
+ Hits 20230 20292 +62
+ Misses 19 2 -17
+ Partials 15 0 -15
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Signed-off-by: Nicko Guyer <nicko.guyer@kaleido.io>
Signed-off-by: David Echelberger <eberger727@gmail.com>
peterbroadhurst
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks both for the updates to use the CLI.
Tutorial to guide user through creating a Custom Identity in FireFly.
References #621