Skip to content

Conversation

@shorsher
Copy link
Member

@shorsher shorsher commented Sep 22, 2022

Fixes error where namespace was not set when resolving contract API on create. This resulted in contract listener url's being broken in the POST response.

When generating contract URL's, always use the ContractManager namespace.

closes #1067

@codecov-commenter
Copy link

codecov-commenter commented Sep 22, 2022

Codecov Report

Merging #1070 (0347bd2) into main (1f31807) will not change coverage.
The diff coverage is 100.00%.

❗ Current head 0347bd2 differs from pull request most recent head 58a2014. Consider uploading reports for the commit 58a2014 to get more accurate results

@@           Coverage Diff           @@
##             main    #1070   +/-   ##
=======================================
  Coverage   99.99%   99.99%           
=======================================
  Files         307      307           
  Lines       20294    20294           
=======================================
  Hits        20292    20292           
  Misses          2        2           
Impacted Files Coverage Δ
internal/definitions/sender_contracts.go 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@shorsher shorsher changed the title process namespace before resolving contract API use cm.namespace when generating contract URL's Sep 22, 2022
Signed-off-by: Alex Shorsher <alex.shorsher@kaleido.io>
@shorsher shorsher merged commit df117ab into hyperledger:main Sep 22, 2022
@shorsher shorsher deleted the fix-api-uri branch September 22, 2022 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

swagger/openapi url response is missing namespace in POST response

3 participants