Added more tests to the Fabric plugin for 100% coverage #261
Conversation
jimthematrix
requested review from
awrichar,
nguyer and
peterbroadhurst
as code owners
internal/blockchain/fabric/certs.go
Outdated
|
|
||
| // borrowed from fabric-chaincode-go to guarantee the same | ||
| // resolution of "DN" string from x509 certs | ||
| // https://github.com/hyperledger/fabric-chaincode-go/blob/main/pkg/cid/cid.go |
There was a problem hiding this comment.
Is this link still relevant now that most of the method has been removed and replaced with the existing .String() behavior?
There was a problem hiding this comment.
good catch, not any longer
| r <- []byte(`!badjson`) // ignored bad json | ||
| r <- []byte(`"not an object"`) // ignored wrong type | ||
| r <- data | ||
| e.ctx.Done() |
There was a problem hiding this comment.
Can we check anything to validate that the events were actually processed?
There was a problem hiding this comment.
not easily, as no actions are taken in the error branches except logging an error.
Codecov Report
@@ Coverage Diff @@
## main #261 +/- ##
===========================================
+ Coverage 99.53% 100.00% +0.46%
===========================================
Files 217 217
Lines 12181 12212 +31
===========================================
+ Hits 12124 12212 +88
+ Misses 42 0 -42
+ Partials 15 0 -15
Continue to review full report at Codecov.
|
awrichar
left a comment
awrichar
left a comment
There was a problem hiding this comment.
Looks pretty good to me. I left some minor comments - you can decide if they warrant any extra tweaks.
Signed-off-by: Jim Zhang <jim.zhang@kaleido.io>
jimthematrix
force-pushed
the
fabric-tests
branch
from
4a73d36 to
8b7212d
Compare
3 participants
No description provided.