New GET routes for tokens #275
Conversation
Signed-off-by: David Echelberger <david.echelberger@kaleido.io>
awrichar
requested review from
nguyer,
nickgaski and
peterbroadhurst
as code owners
peterbroadhurst
left a comment
peterbroadhurst
left a comment
There was a problem hiding this comment.
I think TokenTransfer should be returned rather than TokenAccount on the transfers routes.
| FilterFactory: database.TokenTransferQueryFactory, | ||
| Description: i18n.MsgTBD, | ||
| JSONInputValue: nil, | ||
| JSONOutputValue: func() interface{} { return []*fftypes.TokenAccount{} }, |
There was a problem hiding this comment.
Is this TokenAccount?
There was a problem hiding this comment.
Good catch, should be TokenTransfer. Looks like a pre-existing bug, but I'll address it here.
| FilterFactory: database.TokenTransferQueryFactory, | ||
| Description: i18n.MsgTBD, | ||
| JSONInputValue: nil, | ||
| JSONOutputValue: func() interface{} { return []*fftypes.TokenAccount{} }, |
There was a problem hiding this comment.
Again here on TokenAccount
| if name == "" { | ||
| return i18n.NewError(ctx, i18n.MsgMissingTokensPluginConfig) | ||
| } | ||
| if err = fftypes.ValidateFFNameField(ctx, name, "name"); err != nil { |
There was a problem hiding this comment.
great thought to add this here, and stop people getting themselves into a situation where the connector can't be returned 👍
Signed-off-by: Andrew Richardson <andrew.richardson@kaleido.io>
Codecov Report
@@ Coverage Diff @@
## main #275 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 219 223 +4
Lines 12317 12356 +39
=========================================
+ Hits 12317 12356 +39
Continue to review full report at Codecov.
|
3 participants
Reviewed separately on a branch:
Squashed together here for upstreaming.