Skip to content

Conversation

@dechdev
Copy link
Contributor

@dechdev dechdev commented Oct 21, 2021

To support the new Tokens Page in the UI, an endpoint to get token pools by name or ID and to get token transfers by ID is needed.

GET /namespaces/<namespace>/tokens/pools/{nameOrID} returns all token pools with specified name or ID
GET /namespaces/<namespace>/tokens/transfers/{transferID} returns token transfer with specified ID

@codecov-commenter
Copy link

codecov-commenter commented Oct 21, 2021

Codecov Report

Merging #278 (c643683) into main (bce659a) will not change coverage.
The diff coverage is 100.00%.

❗ Current head c643683 differs from pull request most recent head 38959c4. Consider uploading reports for the commit 38959c4 to get more accurate results
Impacted file tree graph

@@            Coverage Diff            @@
##              main      #278   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          223       225    +2     
  Lines        12374     12403   +29     
=========================================
+ Hits         12374     12403   +29     
Impacted Files Coverage Δ
internal/assets/manager.go 100.00% <ø> (ø)
...al/apiserver/route_get_token_pool_by_name_or_id.go 100.00% <100.00%> (ø)
...ernal/apiserver/route_get_token_transfers_by_id.go 100.00% <100.00%> (ø)
internal/assets/token_pool.go 100.00% <100.00%> (ø)
internal/assets/token_transfer.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bce659a...38959c4. Read the comment docs.

Signed-off-by: David Echelberger <david.echelberger@kaleido.io>
Signed-off-by: David Echelberger <david.echelberger@kaleido.io>
@shorsher shorsher merged commit 818b5ed into hyperledger:main Oct 21, 2021
@shorsher shorsher deleted the tokens-by-id branch October 21, 2021 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants