Skip to content

Conversation

@peterbroadhurst
Copy link
Contributor

Helm chart still had -labs in the names

Signed-off-by: Peter Broadhurst <peter.broadhurst@kaleido.io>
@codecov-commenter
Copy link

Codecov Report

Merging #288 (724f931) into main (70d1022) will not change coverage.
The diff coverage is n/a.

❗ Current head 724f931 differs from pull request most recent head 658aaf0. Consider uploading reports for the commit 658aaf0 to get more accurate results
Impacted file tree graph

@@            Coverage Diff            @@
##              main      #288   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          225       225           
  Lines        12410     12410           
=========================================
  Hits         12410     12410           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 70d1022...658aaf0. Read the comment docs.

@nguyer
Copy link
Contributor

nguyer commented Oct 26, 2021

Should we merge this one if the Helm task is still failing? I don't think this PR makes it any worse than it already was.

@onelapahead
Copy link
Contributor

Can close this in favor of #340

@awrichar awrichar merged commit bc26802 into hyperledger:main Dec 2, 2021
@awrichar awrichar deleted the fix-imgnames branch December 2, 2021 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants