Skip to content

Conversation

@onelapahead
Copy link
Contributor

@onelapahead onelapahead commented Nov 30, 2021

Noticed these when trying to deploy FireFly in live environments via the Helm chart

Fixes

  • psql_url needs to be a key in the firefly-config Secret when using the migration job
  • uses for ghcr.io/hyperledger/ for Docker repos
  • no longer uses latest image tag, and instead uses v0.9.2 for DX and .Chart.AppVersion for FF (which is set to v0.11.1)
  • error message for when organization.key is not set is misleading since it reference the deprecated organization.identity

Signed-off-by: hfuss <haydenfuss@gmail.com>
@codecov-commenter
Copy link

Codecov Report

Merging #340 (cc5c991) into main (dab7664) will not change coverage.
The diff coverage is n/a.

❗ Current head cc5c991 differs from pull request most recent head 15f5da0. Consider uploading reports for the commit 15f5da0 to get more accurate results
Impacted file tree graph

@@            Coverage Diff            @@
##              main      #340   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          234       234           
  Lines        12793     12793           
=========================================
  Hits         12793     12793           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dab7664...15f5da0. Read the comment docs.

MsgParentIdentityNotFound = ffm("FF10214", "Organization with identity '%s' not found in identity chain for %s '%s'")
MsgInvalidSigningIdentity = ffm("FF10215", "Invalid signing identity")
MsgNodeAndOrgIDMustBeSet = ffm("FF10216", "node.name, org.name and org.identity must be configured first", 409)
MsgNodeAndOrgIDMustBeSet = ffm("FF10216", "node.name, org.name and org.key must be configured first", 409)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unrelated to the chart changes, but this error message confused me a bit since this is whats displayed when neither org.key nor org.identity are set (which was happening w/ my chart installation due to a bug on my end). It should references the new config key instead rather than the deprecated one.

Copy link
Contributor

@awrichar awrichar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine to me. Note that I just tagged new versions of dependent repos, so not sure if that implies a change here (ie bumping the dataexchange version).

Signed-off-by: hfuss <haydenfuss@gmail.com>
@onelapahead
Copy link
Contributor Author

@awrichar thanks for the review! Pushed an update to use the latest FF and DX releases. This should be good to merge whenever you're ready unless @peterbroadhurst needs to give it a look.

@onelapahead onelapahead mentioned this pull request Dec 1, 2021
@awrichar awrichar merged commit 09cfefd into hyperledger:main Dec 2, 2021
@awrichar awrichar deleted the chart-fixes branch December 2, 2021 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants