Only send transfer message if token transfer is successful #297
Conversation
awrichar
requested review from
nguyer,
nickgaski and
peterbroadhurst
as code owners
Codecov Report
@@ Coverage Diff @@
## main #297 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 224 225 +1
Lines 12387 12421 +34
=========================================
+ Hits 12387 12421 +34
Continue to review full report at Codecov.
|
awrichar
force-pushed
the
failtransfer
branch
from
912536c to
21a9016
Compare
Signed-off-by: Andrew Richardson <andrew.richardson@kaleido.io>
The message is now stashed away on the Operation inputs, then loaded and sent by the event manager if the transfer succeeds. Signed-off-by: Andrew Richardson <andrew.richardson@kaleido.io>
awrichar
force-pushed
the
failtransfer
branch
from
21a9016 to
eda9995
Compare
docs/swagger/swagger.yaml
Outdated
| type: array | ||
| state: | ||
| enum: | ||
| - notready |
There was a problem hiding this comment.
No big objectection to notready, but in general I have a bell that pings when I see a negative.
Wonder if any of these would work?
stagedblockedpreprocessinginitializing
There was a problem hiding this comment.
Yea, actually staged was my first take on this. Maybe should go back to that.
peterbroadhurst
left a comment
peterbroadhurst
left a comment
There was a problem hiding this comment.
Looks great 👍
One minor spelling related question to think about, and see if you want to make a change or not.
| } | ||
|
|
||
| // Special handling for OpTypeTokenTransfer, which writes an event when it fails | ||
| if op.Type == fftypes.OpTypeTokenTransfer && txState == fftypes.OpStatusFailed { |
There was a problem hiding this comment.
Mental note (not suggesting any change): the next time we find this pattern, we might want to do something a little generic around failure event mapping, rather than building a bunch of switches down here.
peterbroadhurst
left a comment
peterbroadhurst
left a comment
There was a problem hiding this comment.
👍 marking approval here to allow merging when the spelling change and. merge conflicts are done.
Signed-off-by: Andrew Richardson <andrew.richardson@kaleido.io>
3 participants
This is a rework of #279 - please see the original notes on that PR, which still apply here.
Falls under architecture item #218.
It contains the commits from #283 and #296 as pre-requisites, so those should be reviewed first. Only the last 2 commits are net new code.