v0.11.x backport: Add ping/pong heartbeating to WSClient, and fix concurrent map on config #430
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Peter Broadhurst <peter.broadhurst@kaleido.io>
Signed-off-by: Peter Broadhurst <peter.broadhurst@kaleido.io>
Signed-off-by: Peter Broadhurst <peter.broadhurst@kaleido.io>
Signed-off-by: Peter Broadhurst <peter.broadhurst@kaleido.io>
Signed-off-by: Peter Broadhurst <peter.broadhurst@kaleido.io>
Signed-off-by: Peter Broadhurst <peter.broadhurst@kaleido.io>
peterbroadhurst
changed the title
peterbroadhurst
changed the title
awrichar
reviewed
Jan 21, 2022
| MsgTooLargeBroadcast = ffm("FF10327", "Message size %.2fkb is too large for the max broadcast batch size of %.2fkb", 400) | ||
| MsgTooLargePrivate = ffm("FF10328", "Message size %.2fkb is too large for the max private message size of %.2fkb", 400) | ||
| MsgManifestMismatch = ffm("FF10329", "Manifest mismatch overriding '%s' status as failure: '%s'", 400) | ||
| MsgWSHeartbeatTimeout = ffm("FF10330", "Websocket heartbeat timed out after %.2fms", 500) |
Contributor
There was a problem hiding this comment.
I think some additional strings were pulled in beyond what's actually needed for this change... is that intentional?
awrichar
approved these changes
Jan 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #420