Add convenience URL /transactions/{txnid}/blockchainevents

[awrichar]

No description provided.

[codecov-commenter]

Codecov Report

Merging #446 (468b59e) into main (4bc6c91) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main      #446   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          278       279    +1     
  Lines        14981     14995   +14     
=========================================
+ Hits         14981     14995   +14     

Impacted Files	Coverage Δ
internal/orchestrator/orchestrator.go	100.00% <ø> (ø)
...ternal/apiserver/route_get_txn_blockchainevents.go	100.00% <100.00%> (ø)
internal/apiserver/route_get_txn_ops.go	100.00% <100.00%> (ø)
internal/orchestrator/data_query.go	100.00% <100.00%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4bc6c91...468b59e. Read the comment docs.

[peterbroadhurst]

One trivial suggestion, with approval.

[peterbroadhurst]

Shouldn't need the & here I think as arrays are a reference type, although it doesn't really matter.

[awrichar]

I copy-pasted this, but your comment prompted me to do a quick investigation... it actually looks like the Swagger generation for the output schema is only correct if you do include the &. So for this route it correctly indicates that it will return an array of BlockchainEvent. But for other routes that don't return a pointer, it's a bit broken - such as for /transactions, which returns []*fftypes.Transaction, the Swagger indicates it will return a single Transaction object.

I take this to mean we should add the & everywhere on array returns, or investigate why the Swagger generation behaves this way.

[peterbroadhurst]

Thanks for digging! Will merge based on this and raise an issue

[awrichar]

Thanks, I see #449