Skip to content

Conversation

@peterbroadhurst
Copy link
Contributor

See #451

Signed-off-by: Peter Broadhurst <peter.broadhurst@kaleido.io>
@codecov-commenter
Copy link

Codecov Report

Merging #461 (e8f40cf) into main (c1f9507) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #461   +/-   ##
=======================================
  Coverage   99.92%   99.92%           
=======================================
  Files         266      266           
  Lines       15101    15101           
=======================================
  Hits        15090    15090           
  Misses         11       11           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c1f9507...e8f40cf. Read the comment docs.

Copy link
Contributor

@nickgaski nickgaski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Adding baseurl: /firefly allows all links to resolve in #451 and persists a successful local build.

@awrichar awrichar merged commit f262c5c into hyperledger:main Feb 2, 2022
@awrichar awrichar deleted the fix-prefix branch February 2, 2022 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants