Skip to content

Conversation

@peterbroadhurst
Copy link
Contributor

Notices these were missing when investigating a set of performance logs

Signed-off-by: Peter Broadhurst <peter.broadhurst@kaleido.io>
@codecov-commenter
Copy link

codecov-commenter commented Feb 7, 2022

Codecov Report

Merging #488 (47348df) into main (0c7b08b) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##              main      #488   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          267       267           
  Lines        15239     15243    +4     
=========================================
+ Hits         15239     15243    +4     
Impacted Files Coverage Δ
internal/broadcast/message.go 100.00% <100.00%> (ø)
internal/events/aggregator.go 100.00% <100.00%> (ø)
internal/privatemessaging/message.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0c7b08b...47348df. Read the comment docs.

@peterbroadhurst
Copy link
Contributor Author

Test failure is another instance of #487 - kicking off new run

Copy link
Contributor

@nguyer nguyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@nguyer nguyer merged commit d90d176 into hyperledger:main Feb 8, 2022
@nguyer nguyer deleted the extra-logs branch February 8, 2022 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants