Fix fabric event timestamp parsing #491
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jim Zhang <jim.zhang@kaleido.io>
jimthematrix
requested review from
awrichar,
nguyer and
peterbroadhurst
as code owners
Codecov Report
@@ Coverage Diff @@
## main #491 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 267 267
Lines 15239 15236 -3
=========================================
- Hits 15239 15236 -3
Continue to review full report at Codecov.
|
peterbroadhurst
approved these changes
Feb 8, 2022
Contributor
peterbroadhurst
left a comment
peterbroadhurst
left a comment
There was a problem hiding this comment.
Reviewed the FabConnect code, and this change is because the JSON payload contains a JSON number (Go float64) rather than a string. The GetInt64 handles various types (number/string, in decimal or hex).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Jim Zhang jim.zhang@kaleido.io