Skip to content

Conversation

@awrichar
Copy link
Contributor

@awrichar awrichar commented Feb 8, 2022

Follow the convention of all other plugins by passing a request ID into the
connector, rather than reading one from the connector response. This will be
enforced as a requirement for future connectors, so backend_id is removed from
the operations table.

Depends on hyperledger/firefly-dataexchange-https#54

Copy link
Contributor

@peterbroadhurst peterbroadhurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Noting it has a co-req with hyperledger/firefly-dataexchange-https#54 meaning a hard dependency on upgrading DX with this.

@codecov-commenter
Copy link

codecov-commenter commented Feb 8, 2022

Codecov Report

Merging #497 (2319930) into main (d90d176) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##              main      #497   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          267       267           
  Lines        15240     15251   +11     
=========================================
+ Hits         15240     15251   +11     
Impacted Files Coverage Δ
internal/assets/token_pool.go 100.00% <ø> (ø)
internal/assets/token_transfer.go 100.00% <ø> (ø)
internal/batchpin/batchpin.go 100.00% <ø> (ø)
internal/broadcast/manager.go 100.00% <ø> (ø)
internal/contracts/manager.go 100.00% <ø> (ø)
internal/database/sqlcommon/operation_sql.go 100.00% <ø> (ø)
pkg/fftypes/transport_wrapper.go 100.00% <ø> (ø)
internal/dataexchange/dxhttps/dxhttps.go 100.00% <100.00%> (ø)
internal/events/dx_callbacks.go 100.00% <100.00%> (ø)
internal/privatemessaging/privatemessaging.go 100.00% <100.00%> (ø)
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d90d176...2319930. Read the comment docs.

@awrichar
Copy link
Contributor Author

awrichar commented Feb 8, 2022

Yep - good news is it won't fail anything without the change (as testified by the E2E tests here), but it will result in a bunch of DX operations being left "pending".

Planning to merge this with a manifest.json change after the DX PR goes in.

Follow the convention of all other plugins by passing a request ID into the
connector, rather than reading one from the connector response. This will be
enforced as a requirement for future connectors, so backend_id is removed from
the operations table.

Signed-off-by: Andrew Richardson <andrew.richardson@kaleido.io>
Size int64 `json:"size"`
Error string `json:"error"`
Manifest string `json:"manifest"`
Info fftypes.JSONObject `json:"info"`
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@peterbroadhurst @gabriel-indik I wanted to call special attention to this change. I don't actually see any dataexchange events that include "info" in their payload, so I don't think it breaks anything. Was this just added as a possible future plug point?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@awrichar the Info field is actually expected. After reviewing the latest changes I realized this is something that is going to be coming from Data Exchange. This is, instead of having to deal with each individual type of response Data Exchange produces, the information will always be encapsulated under the "info" JSON object.

Signed-off-by: Andrew Richardson <andrew.richardson@kaleido.io>
Signed-off-by: Andrew Richardson <andrew.richardson@kaleido.io>
@awrichar awrichar merged commit cf27fa9 into hyperledger:main Feb 9, 2022
@awrichar awrichar deleted the dxrequest branch February 9, 2022 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants