go-migrate in Dockerfile #524
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: hfuss <haydenfuss@gmail.com>
onelapahead
requested review from
awrichar,
nguyer and
peterbroadhurst
as code owners
Contributor
Author
|
See hyperledger/firefly-helm-charts#20 for more information of about how these utilities were previously downloaded and how they are used. |
Dockerfile
Outdated
| && apk add --update --no-cache postgresql-client curl jq \ | ||
| && curl -sL "https://github.com/golang-migrate/migrate/releases/download/$(curl -sL https://api.github.com/repos/golang-migrate/migrate/releases/latest | jq -r '.name')/migrate.linux-amd64.tar.gz" | tar xz \ | ||
| && chmod +x ./migrate \ | ||
| && cp ./migrate /usr/bin/migrate |
Codecov Report
@@ Coverage Diff @@
## main #524 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 275 275
Lines 15812 15812
=========================================
Hits 15812 15812 Continue to review full report at Codecov.
|
peterbroadhurst
approved these changes
Feb 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #521, realized the chart scripts also were downloading
go-migrateas well so this adds that.Definitely further re-enforces @peterbroadhurst's comment about a separate
utiltitytag or image for firefly in the future.