Skip to content

Conversation

@peterbroadhurst
Copy link
Contributor

In PR chain with #593

From observations via pprof:

Excessive SQL connection overhead:
image

Cache bypass:
image

profile002.pdf

@codecov-commenter
Copy link

codecov-commenter commented Mar 10, 2022

Codecov Report

Merging #594 (b2c2913) into main (e05e166) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##              main      #594   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          305       306    +1     
  Lines        18013     18023   +10     
=========================================
+ Hits         18013     18023   +10     
Impacted Files Coverage Δ
internal/config/config.go 100.00% <100.00%> (ø)
internal/database/sqlcommon/config.go 100.00% <100.00%> (ø)
internal/database/sqlcommon/sqlcommon.go 100.00% <100.00%> (ø)
internal/privatemessaging/groupmanager.go 100.00% <100.00%> (ø)
internal/privatemessaging/privatemessaging.go 100.00% <100.00%> (ø)
internal/privatemessaging/recipients.go 100.00% <100.00%> (ø)
pkg/fftypes/transaction.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e05e166...b2c2913. Read the comment docs.

@awrichar
Copy link
Contributor

Approved, although it will need to be merged after comments on #593 are addressed. codecov also shows a potential coverage problem, but unsure if it's real.

…ache

Signed-off-by: Peter Broadhurst <peter.broadhurst@kaleido.io>
Signed-off-by: Peter Broadhurst <peter.broadhurst@kaleido.io>
Signed-off-by: Peter Broadhurst <peter.broadhurst@kaleido.io>
@peterbroadhurst peterbroadhurst merged commit 7f5c307 into hyperledger:main Mar 11, 2022
@peterbroadhurst peterbroadhurst deleted the db-tuning branch March 11, 2022 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants