-
Notifications
You must be signed in to change notification settings - Fork 242
Support tokens only namespaces #896
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## main #896 +/- ##
==========================================
+ Coverage 99.96% 99.97% +0.01%
==========================================
Files 298 298
Lines 19405 19471 +66
==========================================
+ Hits 19399 19467 +68
+ Misses 5 4 -1
+ Partials 1 0 -1
Continue to review full report at Codecov.
|
| } | ||
|
|
||
| if inputKey == "" { | ||
| verifierRef, err := im.getDefaultVerifier(ctx) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think probably getDefaultVerifier (and anyone else that calls it) should take in keyNormalizationMode. Then I think you wouldn't need a special branch above - you can just fall down into here and stick the error handling into getDefaultVerifier.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I solved this a bit differently, I didn't see the benefit of adding keyNormalizationMode to getDefaultVerifier after trying. Let me know what you think.
Signed-off-by: Alex Shorsher <alex.shorsher@kaleido.io>
Signed-off-by: Alex Shorsher <alex.shorsher@kaleido.io>
Now, multiparty-disabled namespaces can run without a blockchain plugin:
aggregatoris not started withinEventManager