Skip to content

Conversation

@shorsher
Copy link
Member

Now, multiparty-disabled namespaces can run without a blockchain plugin:

  • All contract routes will be disabled
  • Identity normalizations that rely on a blockchain plugin will either default to the specified input/default key or fail
  • aggregator is not started within EventManager

@codecov-commenter
Copy link

codecov-commenter commented Jul 11, 2022

Codecov Report

Merging #896 (3e42bf5) into main (09d431f) will increase coverage by 0.01%.
The diff coverage is 100.00%.

❗ Current head 3e42bf5 differs from pull request most recent head 6689ae9. Consider uploading reports for the commit 6689ae9 to get more accurate results

@@            Coverage Diff             @@
##             main     #896      +/-   ##
==========================================
+ Coverage   99.96%   99.97%   +0.01%     
==========================================
  Files         298      298              
  Lines       19405    19471      +66     
==========================================
+ Hits        19399    19467      +68     
+ Misses          5        4       -1     
+ Partials        1        0       -1     
Impacted Files Coverage Δ
...ternal/apiserver/route_get_contract_api_by_name.go 100.00% <100.00%> (ø)
...rnal/apiserver/route_get_contract_api_interface.go 100.00% <100.00%> (ø)
...rnal/apiserver/route_get_contract_api_listeners.go 100.00% <100.00%> (ø)
internal/apiserver/route_get_contract_apis.go 100.00% <100.00%> (ø)
internal/apiserver/route_get_contract_interface.go 100.00% <100.00%> (ø)
...erver/route_get_contract_interface_name_version.go 100.00% <100.00%> (ø)
...nternal/apiserver/route_get_contract_interfaces.go 100.00% <100.00%> (ø)
...erver/route_get_contract_listener_by_name_or_id.go 100.00% <100.00%> (ø)
internal/apiserver/route_get_contract_listeners.go 100.00% <100.00%> (ø)
...ternal/apiserver/route_post_contract_api_invoke.go 100.00% <100.00%> (ø)
... and 15 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 09d431f...6689ae9. Read the comment docs.

}

if inputKey == "" {
verifierRef, err := im.getDefaultVerifier(ctx)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think probably getDefaultVerifier (and anyone else that calls it) should take in keyNormalizationMode. Then I think you wouldn't need a special branch above - you can just fall down into here and stick the error handling into getDefaultVerifier.

Copy link
Member Author

@shorsher shorsher Jul 11, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I solved this a bit differently, I didn't see the benefit of adding keyNormalizationMode to getDefaultVerifier after trying. Let me know what you think.

Signed-off-by: Alex Shorsher <alex.shorsher@kaleido.io>
Signed-off-by: Alex Shorsher <alex.shorsher@kaleido.io>
@shorsher shorsher merged commit ca1f963 into hyperledger:main Jul 13, 2022
@shorsher shorsher deleted the tokens-only branch July 13, 2022 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants